-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#54008 Issue Fix #54058
#54008 Issue Fix #54058
Conversation
Passing name of the Template
Tagging subscribers to this area: @maryamariyan Issue DetailsPassing t.Key (the name of the template).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also add a line similar to
Line 80 in a5d9016
Assert.Contains("Argument 'foo' is not referenced from the logging message", diagnostics[0].GetMessage(), StringComparison.InvariantCulture); |
After
Line 95 in a5d9016
Assert.Equal(DiagnosticDescriptors.TemplateHasNoCorrespondingArgument.Id, diagnostics[0].Id); |
to assert the fix.
Added Logger Fix TestCase
Just added the test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matching test chase with expected case
Just updated the test |
I have tried sifting through the 3 failing tests but I can't tell where the problem is. Any Pointers @maryamariyan What I found:
|
The test failures are unrelated to your changes and are addressed in #54119 I noticed you added one commit per *.xlf file. When you build the |
Oh I presumed I had to had code, I can undo all the commits |
no need to undo. |
ok thanks for the clarification |
just wanted to make sure you've tried building locally as well |
@j0nimost look forward to more contributions in the future :) |
Thank you @maryamariyan |
Sorry for the redundancy @j0nimost. I missed where you had already started a fix/PR for it when I submitted mine. |
Passing t.Key (the name of the template).